visor: register RuntimeLogs on the RPC server#2417
Merged
0pcom merged 1 commit intoskycoin:developfrom May 2, 2026
Merged
Conversation
The hypervisor UI's "view logs" action and 'cli visor logs' both hit Visor.RuntimeLogs() through the RPC client, but the RPC server type (*RPC) had no RuntimeLogs method registered. Stock net/rpc exposes only methods on the registered receiver via reflection, so client calls came back with Rpc: can't find method app-visor.RuntimeLogs. API.RuntimeLogs, Visor.RuntimeLogs, and the rpcClient.RuntimeLogs client wrapper were already in place — the dispatcher in pkg/visor/rpc_visor.go was the missing piece. Add it next to GetRuntimeConfig (same shape: zero-arg in, *string out).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hypervisor UI's "view logs" action and 'cli visor logs' both hit Visor.RuntimeLogs() through the RPC client, but the RPC server type (*RPC) had no RuntimeLogs method registered. Stock net/rpc exposes only methods on the registered receiver via reflection, so client calls came back with
Rpc: can't find method app-visor.RuntimeLogs.
API.RuntimeLogs, Visor.RuntimeLogs, and the rpcClient.RuntimeLogs client wrapper were already in place — the dispatcher in pkg/visor/rpc_visor.go was the missing piece. Add it next to GetRuntimeConfig (same shape: zero-arg in, *string out).
Did you run
make format && make check?Fixes #
Changes:
How to test this PR: